Consolidate configuration handling in data/configuration.rs into xet_config #609
Draft
Consolidate configuration handling in data/configuration.rs into xet_config #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, data/configuration.rs contains a lot of stuff that can now easily be handled by the xet_config system. This PR moves many of these fields into the appropriate groups within xet_config, leaving the repo, endpoint, session, etc. information inside a new struct called SessionContext.
Currently, this is part of the work needed to have a clean Session-based interface; it's a breaking change to the hf_wasm, so needs to be rolled out cleanly (hence the draft status).